Reachability.swift icon indicating copy to clipboard operation
Reachability.swift copied to clipboard

Published 20 hours ago • verified publisher icon ashleymills

Connection `.none` and `.unavailable` are mixed in the code

Open pjechris opened this issue 1 year ago • 0 comments

Hi,

Reading quickly the code I found some places where .none and .unavailable are mixed:

  • Connection.description: unavailable is "no connection" and .none is... "unavailable" 🤔
  • deprecated isReachable: comment says to compare to .none and code compares to... .unavailable 🤔
Screenshot 2023-06-26 at 17 02 36 Screenshot 2023-06-26 at 17 23 02

It makes things very unclear about what's the difference between the two (and misleading).

pjechris avatar Jun 26 '23 15:06 pjechris