lightbox icon indicating copy to clipboard operation
lightbox copied to clipboard

Fix css centering on mobile

Open gusano opened this issue 8 years ago • 3 comments

On some mobiles the modal is not centered (see screenshots below). This fixes it by using flexbox.

Before

deepinscreenshot_select-area_20170902211437 deepinscreenshot_select-area_20170902211452

After

deepinscreenshot_select-area_20170902211525 deepinscreenshot_select-area_20170902211540

gusano avatar Sep 02 '17 19:09 gusano

I don't know how minifying css is done (didn't use Grunt in a looong time) but it looks like dist/ekko-lightbox.min.css hasn't changed since a year ago, otherwise I would happily add the change there as well. Meanwhile I'm gonna use my fork :)

Thanks for the nice lib!

gusano avatar Sep 02 '17 19:09 gusano

As this plugin uses bootstraps modals, isn't this a problem in bootstrap rather than the plugin?

ashleydw avatar Sep 03 '17 20:09 ashleydw

Indeed it's the default behaviour of bootstrap modal. It's not only on mobile: bootstrap modal is always shown at the top of the page. (On desktop as the display is landscape we will not notice it for classic pictures, except for panoramic images.)

Even if it's the default modal behaviour, the result would be nicer if the image was centred vertically :)

VirginieGarcin avatar Oct 05 '17 06:10 VirginieGarcin