lightbox icon indicating copy to clipboard operation
lightbox copied to clipboard

Published 20 hours ago • verified publisher icon ashleydw

Bower references incorrect bootstrap version

Open kralmichal opened this issue 8 years ago • 4 comments

If you don't have bootstrap already loaded via custom bower.json, then bower downloads latest bootstrap that satisfies ">= 4.0.0-alpha.3" which is currently 4.0.0-alpha.6. Since Alpha 6 was rewritten a lot it breaks website. To be safe you have to load correct version manually. Why even build library on alpha version of another library?

kralmichal avatar Feb 22 '17 16:02 kralmichal

you're correct, that's a mistake in the bower file.

I don't understand your question regarding an alpha version.

Feel free to open a pr fixing the bower file

ashleydw avatar Feb 22 '17 17:02 ashleydw

I'll probably send a PR over the weekend.

The comment regarding an alpha version is that IMHO building library with dependency on library still in alpha is not right.

kralmichal avatar Feb 23 '17 08:02 kralmichal

great 👍

you can use BS3 if you prefer, it is backwards compatible

ashleydw avatar Feb 23 '17 22:02 ashleydw

I hava a problem use BS3.3: Uncaught TypeError: modal.handleUpdate is not a function

zxz19 avatar Mar 03 '17 13:03 zxz19