Ashley Broughton

en-AU - Queen's birthday. State differences.

3

The Queen's birthday in the en-AU strategy has been implemented to be the 2nd Monday in June. This is applicable across most states, however there are exceptions. How would these...

Error when creating article as guest

4

https://github.com/ashleybroughton/CoreWiki/blame/dev/CoreWiki/Pages/Create.cshtml.cs#L62 

Implied consent for password reset

1

Should we remove this check for consent? https://github.com/csharpfritz/CoreWiki/blob/dev/CoreWiki.Notifications/NotificationService.cs#L89-L92 It not only doesn't stop processing after the consent check fails, but if a user requested a password reset, isn't consent implied?...

The page pops up that asks you whether you want to create the article, but the LinksToCreate model is empty when it gets through to OnPostCreateLinksAsync.


We're currently handling POST requests from the CreateComments component in the page where the component is embedded. e.x. https://github.com/csharpfritz/CoreWiki/blob/dev/CoreWiki/Pages/Details.cshtml.cs#L87-L108 Shouldn't we be handling the post of the comment creation in...

First database user is not an administrator

3

The database starts fresh without any users and the first user who registers doesn't get added to this role and is unable to delete articles. Should we ensure a default...

Default homepage. Migration or first start wizard?

1

**TL;DR** We get migration problems because Article Guids and Published date are seen as changed each time EntityFramework checks them against our model. https://github.com/csharpfritz/CoreWiki/blob/dev/CoreWiki/Models/ApplicationDbContext.cs#L25-L26 --- The way we are generating...

[Security] Require password or 2FA verification for account changes

1

If the site is vulnerable to XSS an attacker could change profile information for a user without their interaction. An attacker could leave a comment on the home page that...