NppFTP doesn't use Npp Style configuration

[ramiy]

trafficstars

NPP allows to change theme from Settings > Style Configuration screen.

Seems like NppFTP uses its own styles, it doesn't use the theme style.

It should be fixed.

[vlakoff]

On the other hand, I really like this white background. (left side in my case, so that I don't have the code near to the edge of my screen)

I don't use the recent Workspace feature only because of that. :joy:

[ramiy]

@vlakoff if you like the white background, choose white style. Others like black background, they should see black backgrounds. Green background lovers should see green backgrounds.

The users should choose what they loves. The software needs to comply to user chooses.

[vlakoff]

I do use a Notepad++ style with dark background. But all my plugin panels (Light Explorer, NppFTP, SourceCookifier) have white backgrounds, which clearly distinguishes them from the code view.

Ideally, plugin background should be customisable: "inherit" (use Notepad++ background color) or a specified custom color.

[ElliotNB]

+1 for this

@ashkulz @chcg Are you planning to support this functionality? It'd be a great UX improvement if we were able make the background color of the NppFTP plugin match that of the text editor background. Even if it doesn't read from the primary Notepad++ style configuration, just being able to set the NppFTP plugin colors manually would be a huge improvement.

[chcg]

Currently I'm not aware how to take over the background colour from the current active theme. Would need some further investigation or some hint\example how to do it. So I think there will be no shortterm fix on this topic.

[ElliotNB]

@donho Would you be able to advise on how the NppFTP plugin might take over the background color from the current active theme? NppFTP is one of the most popular plugins for Notepad++ and it'd really help the overall UX experience if it were possible to set the NppFTP background color to match whatever background color has been set to the main text editing window.

[drewwesley]

I'm in total agreement of this feature for better UI uniformity/consistency, less eye strain.

[ElliotNB]

@ashkulz @chcg Just checking back in -- any luck finding time to investigate a possible solution for this? I know a lot of us use dark themes with Notepad++ and it would be wonderful to have the NppFTP dark as well.

@donho Any chance that you could help point @chcg in the right direction?

[donho]

@chcg @ElliotNB Here are 2 needed API:

	#define NPPM_GETEDITORDEFAULTFOREGROUNDCOLOR    (NPPMSG + 90)
	// INT NPPM_GETEDITORDEFAULTFOREGROUNDCOLOR(0, 0)
	// Return: current editor default foreground color. You should convert the returned value in COLORREF

	#define NPPM_GETEDITORDEFAULTBACKGROUNDCOLOR    (NPPMSG + 91)
	// INT NPPM_GETEDITORDEFAULTBACKGROUNDCOLOR(0, 0)
	// Return: current editor default background color. You should convert the returned value in COLORREF

And search setBackgroundColor in Notepad++ project your will see how different panels set their background color.

[ElliotNB]

@donho Thank you!

[ElliotNB]

@ashkulz Any chance you'd be able to take a look at this with the tips provided by donho? Thank you!

[ashkulz]

@ElliotNB I haven't used Windows in ~5 years, @chcg is the maintainer :slightly_smiling_face:

That said, I'm pretty sure a PR would be reviewed/merged more quickly :+1:

[chcg]

See https://github.com/funap/npp-explorer-plugin/blob/515e1e5923479c1fb347e4a458e609406fa4573d/Explorer/src/MISC/NppInterface.cpp#L67-L75 on how to implement the retrieval of the foreground/background colours.

They need to be used at:

https://github.com/ashkulz/NppFTP/blob/master/src/Windows/OutputWindow.cpp#L302-L316

for the output window.

[MIOsystems]

Please make it customizable. Its a shame that this plugin doesn't follow the theme settings of his master.

[zitot]

EDIT: I AM AN IDIOT. I didn't realize nppftp already follows styling of the NPP window its attached to, it just doesn't update. When I was testing my build that possibility did not enter my mind. Sorry for the false alert. What happened was I'd noticed nppftp inherit styling from a window. so if i made a new window, changed the style on the new window, and only after that open NppFTP, it would grab the style from that window. of course it doesn't update. Please see it in action, it might at least be useful to some person here who needs a quick fix to style the ftp window. I'll try again this weekend.