AKSwiftSlideMenu icon indicating copy to clipboard operation
AKSwiftSlideMenu copied to clipboard

Bug related to changing to same view controller

Open muvaf opened this issue 7 years ago • 1 comments

Hi,

Thanks for the work! But, I noticed a bug. To replicate:

  1. Click menu button
  2. Select the same view controller option with the one you have now
  3. Click again to menu button and it doesn't work.
  4. Click again now it works but view is messed up.

Problem is with sender.tag use. I fixed it by checking iif (view.subviews.last?.restorationIdentifier == "SlideMenuView") insted of checking for sender's tag. That seemed cleaner and more generic to me and also fixed the problem.

Also I made slidemenuvc a property of BaseViewController so that it doesn't initialize every time.

muvaf avatar Nov 20 '16 21:11 muvaf

@bymafmaf send a pull request

Raafas avatar Jan 25 '17 10:01 Raafas