ashida

Results 38 comments of ashida

I'm misreading the intent of this too! If anything, stop the slow PCRE2 unicode check if you can, when transcoding is done internally. This is because it is guaranteed to...

> We should also fix the encoding selection to be consistent across both `--engine auto` and `--pcre2`. The reason for this is that when "--pcre2" is set and no encoding...

https://github.com/BurntSushi/ripgrep/blob/9b01a8f9ae53ebcd05c27ec21843758c2c1e823f/crates/searcher/src/searcher/mod.rs#L795-L799 This is where we determine if transcoding is required. It should be noted here that if the encoding is set to "auto" and UTF-8 without BOM is given, transcoding...

Oh...and let's get back to the original problem of this issue. > Probably one way to fix this here is to change the look-ahead context slicing to be UTF-8 aware...

I thought of two solutions to this. 1. Programs should always, at all times, decode and treat the file as a string or transcode it to UTF-8, instead of treating...

That's good to know. I'm sorry for the massive amount of pointless garbage I've been dropping...

It seems to me that there is one solution for now that correctly specifies the dependencies for this. That is **OptionalPeerDependencies**([PeerDependencies](https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependencies))([Optional](https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependenciesmeta)) This feature allows package A to be associated with...

This would be a hell of a dependency.

...Why isn't one of react and react-is in the other's peerdependencies in the first place?

... History tells us that many cases similar to this have been solved by the passage of time and fashion. Well, that is, by creating another, better solution while the...