danger-ruby-swiftlint icon indicating copy to clipboard operation
danger-ruby-swiftlint copied to clipboard

Published 20 hours ago • verified publisher icon ashfurrow

Danger-JS version

Open NachoSoto opened this issue 7 years ago • 5 comments

I couldn't find anything: is there a Danger-JS version of this plugin? If not I guess I'll switch to using the Ruby version, or is it possible to have 2 Dangerfiles?

NachoSoto avatar Dec 06 '17 22:12 NachoSoto

Good question! So this is something Orta and I have discussed before. There is no Danger-JS version of the plugin but what we're looking to do is move away from Ruby's Danger altogether. Danger-Swift (which is just Danger-JS under the hood over a JSON bridge) was recently modified to support plugins and I'm planning to build the first Danger-Swift plugin this weekend.

Not a totally satisfying answer I know, but I think moving Danger checks for SwiftLint into a Danger-Swift environment makes sense in the long run. Let me know what you think.

ashfurrow avatar Dec 06 '17 22:12 ashfurrow

Interesting! Thanks for the answer. I'm using the Ruby version for the time being, and I'll plan to migrate to Danger-Swift soon :)

NachoSoto avatar Dec 06 '17 23:12 NachoSoto

Cool! I let you know on this issue when it's ready for use 👍

ashfurrow avatar Dec 07 '17 15:12 ashfurrow

Okay so for anyone following along or wondering why Github is giving 404's, I changed the name of this repo from danger-swiftlint to danger-ruby-swiftlint; then I created a new repo called danger-swiftlint to work on the Danger-Swift plugin for SwiftLint. Still very early stages – onwards and upwards!

ashfurrow avatar Dec 09 '17 16:12 ashfurrow

Alrighty, the plugin should be working now. Let me know if anyone runs into issues.

ashfurrow avatar Dec 24 '17 03:12 ashfurrow