danger-rubocop icon indicating copy to clipboard operation
danger-rubocop copied to clipboard

Feature / Add option for grouping inline comments by line

Open SixiS opened this issue 10 months ago • 2 comments

When there are multiple warnings on a single line, it makes a bit of a mess. Added an option to group the issues on a single line into a single comment.

Lines with a single comment remain unchanged.

# Dangerfile
github.dismiss_out_of_range_messages
rubocop.lint rubocop_cmd: "standardrb", inline_comment: true, group_inline_comments: true
Screenshot 2024-04-12 at 16 16 04

SixiS avatar Apr 12 '24 14:04 SixiS

Note - the bit of extra space at the top is so the markdown generates the list correctly.

Without the extra newline: Screenshot 2024-04-12 at 16 02 27

SixiS avatar Apr 12 '24 14:04 SixiS

This is great -- I wonder if it wouldn't make sense to add it as a feature on Danger itself, though.

iangmaia avatar Apr 23 '24 20:04 iangmaia

Thanks a lot for contributing @SixiS! You've been invited to be a collaborator on this repo – no pressure to accept! If you'd like more information on what this means, check out the Moya contributor guidelines and feel free to reach out with any questions.

Generated by :no_entry_sign: dangerJS

ashfurrow-peril[bot] avatar May 20 '24 23:05 ashfurrow-peril[bot]

I just released this PR in 0.13.0. Thanks again!

ashfurrow avatar May 20 '24 23:05 ashfurrow