Ash Furrow

Results 267 comments of Ash Furrow

I've also gone ahead and opened an app that uses this repo: https://github.com/AshFurrow/C-41 Pull requests welcome :) Not sure how it relates to how you do MVVM, but if it's...

Ah right, of course! Okay cool, I'll dig into that tomorrow at Peer Lab 👍

I'm seeing [the same error on Circle CI](https://github.com/Moya/Moya/issues/2218) ([example failure](https://app.circleci.com/pipelines/github/Moya/Moya/289/workflows/bf31b5f5-01e8-49f7-b03c-5760f81965b3/jobs/4356)). I did some digging and thought I'd share – I have a local workaround but I'm not sure about how...

Hey @jlengstorf – sorry to hear that you're having that problem, it sounds frustrating. That env var looks right, and looking at the code it _should_ work. I'll try to...

Hmm! That is unexpected. Looking at another place that Peril accesses env vars, it should be as straightforward as you've done in your screenshot: https://github.com/danger/peril/blob/01a0357ab8139919499a59ee9e04cdffb28612bf/source/db/getDB.ts#L9 Peril/Danger can be a bit...

Hmmm, okay so I've updated my Peril install on Heroku and have set the env var. I'm still seeing the failure involving `concat`, but I opened a Node REPL on...

I think I have a fix, I'm testing on my Peril instance first and will send a PR once I've verified it works.

Okay, @jlengstorf I've got a PR with a fix up: https://github.com/danger/peril/pull/355 You should be able to pull in that commit immediately and use it. You can optionally remove the environment...

Yeah, I think Danger Swift should follow the example of Cocoa architecture: common things should be easy, and uncommon things should be possible. Orta's clarification in the above comment fits...

I _did_ see some unrelated 403's about not having permissions, I'll send a PR updating the setup docs first.