Ash Furrow

Results 262 comments of Ash Furrow

Okay @marshallxxx – thanks! I've invited you to the organization. Make sure to check out our contributor guidelines and code of conduct here: https://github.com/RxSwiftCommunity/contributors Let me know if you have...

Hey! Yeah that makes sense. Can you update to the latest NSObject-Rx? The property is [currently read/write](https://github.com/RxSwiftCommunity/NSObject-Rx/blob/master/HasDisposeBag.swift#L21) so this might just work. Otherwise, totally welcome to a PR 😄

I see. This case is actually covered by our tests: https://github.com/RxSwiftCommunity/NSObject-Rx/blob/58cd60b8dc7fc52f99423968ad339b0166eb3101/Demo/DemoTests/DemoTests.swift#L8-L13 But I noticed that the `NSObject` is a `var`. I think we've hit some sort of edge case of...

(Sidenote below.) I though I remembered solving a similar problem, of reusing cells getting rid of their subscriptions. I used the `takeUntil()` operator to terminate the signal ... https://github.com/artsy/eidolon/blob/52ae03071efe2c71af2b857831a87e4c00a36c0e/Kiosk/Auction%20Listings/ListingsViewController.swift#L175 ......

I like how explicit it is, and how it removes an aspect of state from my cell class. It's largely a personal preference – either is fine, though in your...

You’re free to open a pull request. Keep the language here clean, please.

Hi there, looks like an issue with your target iOS version: ``` compiling for iOS 10.0, but module 'RxSwift' has a minimum deployment target of iOS 12.0 ``` This is...

`rx.disposeBag` will never equal `label.rx.disposeBag`. If your code is crashing here and you suspect the use of `Then`, try removing it. The compiler will give you different diagnostic messages when...

@adriantofan Is that a `RACObserve` inside another `RACObserve`? That may be the source of the issue.