Aaron Sherber

icon indicating an email [email protected]

icon location Baltimore, MD

Results 118 comments of Aaron Sherber

maybe the default test priority could be 0 instead of maxint

You can change the default priority per class. Take a look at the second example in the README -- you decorate the class with a `[DefaultPriority]` attribute, and then add...

Class Priority Control

It sounds like you're asking about a few different things, most of which have solutions. For test parallelism in general, see the xUnit [docs](https://xunit.net/docs/running-tests-in-parallel). By default, the tests within a...

FluentEmail.AttachFromFileName({fileName}, "content-type", "attachmentName") has "Content-Type" as optional but is ideally expected. Throws error

I think it's actually MimeKit which expects the content type, not this library. The classes in this library are designed to be generic and to work with multiple senders; for...

[BUG] Dispose of file stream in AttachFromFilename

Fixes #269

Node 20

@leafo Can you please update this to use node 20?

Warn of mutated loop variables

Done: https://github.com/lunarmodules/luacheck/issues/116

Fix remaining failing integration tests

I know this PR is only going to an internal branch right now, not to develop, but I think the changes to `PocoData` should be their own PR -- and...

Fix remaining failing integration tests

The `PocoData` changes should be on their own branch with their own PR and then merged to `develop` if they're accepted. Then back out the `PocoData` changes from this branch,...

Fix remaining failing integration tests

Also, sorry to nitpick, but the first line of a git commit message should just be a brief (50 char) summary of what the commit does; the rest can follow...

Fix remaining failing integration tests

Go for it! Note that it's not always appropriate to squash commits. A commit should be a unit of work that has some significance. You might start out with a...