Mikhail Mazurskiy

Results 157 comments of Mikhail Mazurskiy

> This will be true regardless in a serialized proto; said another way, there is no way to have a "set" nil field in a oneof. Now, Go might allow...

@purnesh42H No, I'm not. I think I've answered the questions and it's ready to be merged. Is something off still? Let me know what needs to be changed.

@easwars > There are still a whole lot of comments which are not wrapped at 80-cols. Could you please take care of that. Wrapped. Let me know if I missed...

Related question: I see quite a few calls with a `nil` `pool` - `mem.NewBuffer(&someDataSlice, nil)`. Why not swap this with a type cast like this `mem.SliceBuffer(someDataSlice)`? No need to call...

@easwars This is current master vs this branch (just rebased on master to compare apples vs apples) with the benchmark from #7786. ``` goos: darwin goarch: arm64 pkg: google.golang.org/grpc │...

@dfawley Thanks for the review and merging. I'll wait for the release and post new RAM usage once I get this deployed.