ash icon indicating copy to clipboard operation
ash copied to clipboard

Move lints configuration to manifest

Open filnet opened this issue 2 years ago • 7 comments

This is possible since Rust 1.74.0.

This PR shows what it looks like.

filnet avatar Nov 18 '23 16:11 filnet

Can I close this as "Not planned"?

No problems...

filnet avatar Nov 18 '23 17:11 filnet

I also found it strange that workspace lints can't be overridden at the workspace member level. This behavior is not documented.

filnet avatar Nov 19 '23 11:11 filnet

I dropped the MSRV bump.

What about the lint fixes and the "resolve" warning fix ? Should we keep them ?

filnet avatar Nov 19 '23 11:11 filnet

I moved the ash package specific lints back to the lib.rs file and enabled the workspace lints. This works as "expected".

PS: I don't expect this to be merged. Just showcasing.

filnet avatar Nov 19 '23 11:11 filnet

PS: I don't expect this to be merged. Just showcasing.

Note that everyone gets notifications when you're debugging by means of (force-)pushing.

MarijnS95 avatar Dec 06 '23 15:12 MarijnS95

Note that everyone gets notifications when you're debugging by means of (force-)pushing.

Sorry about that. I'll be more careful next time.

filnet avatar Dec 06 '23 17:12 filnet

Current status / limitations:

  • all common lints are now configured at the workspace level.
  • ash-window now uses the common lints (was using a subset).
  • as mentioned earlier, it is not possible to override or tweak the lints at the workspace member level (but it is still possible to do it from main.rs/lib.rs).

filnet avatar Dec 06 '23 18:12 filnet