ash icon indicating copy to clipboard operation
ash copied to clipboard

Are lifetime specifiers really necessary on every builder?

Open cheako opened this issue 5 years ago • 1 comments

What's the purpose of the marker(s) on builders, is it because of pointers? There are a number of builders that don't contain pointers, not even p_next. Is there any point in having a lifetime on say VertexInputAttributeDescriptionBuilder?

cheako avatar Feb 16 '20 01:02 cheako

I think a PR modifying the generator to omit the lifetime specifier where unused would be welcome.

Ralith avatar Feb 16 '20 02:02 Ralith

Since #602 builder structs have been removed and builder functions have been merged back into the Vulkan structs, and with that only structs containing pointers get a lifetime specifier and pub _marker: PhantomData<&'a ()>.

MarijnS95 avatar May 01 '23 20:05 MarijnS95