asfimport

[Ryan Blue](https://issues.apache.org/jira/browse/PARQUET-137?#comment-15705814) / @rdblue: You can open a pull request from your own repository. Just push a branch to your github fork and open a PR for it from there....

[Oleksiy Sayankin](https://issues.apache.org/jira/browse/PARQUET-137?#comment-15708478): Done: https://github.com/apache/parquet-mr/pull/387

[Viraj Bhat](https://issues.apache.org/jira/browse/PARQUET-137?#comment-15957575): `[~osayankin]` @rdblue is the patch being re-submitted after comments in github. Is this being fixed elsewhere that I do not know of? Viraj

[Timothy Miller](https://issues.apache.org/jira/browse/PARQUET-2139?#comment-17525229) / @theosib-amazon: Of course, I'll be embarrassed if this turns out to just be a bug in my own thrift parser, but everything seems to line up so...

[Timothy Miller](https://issues.apache.org/jira/browse/PARQUET-2139?#comment-17525264) / @theosib-amazon: I've noticed a few places that could be at fault here. I'm looking at 1.13.0-SNAPSHOT, for reference. The first is at line 513 of org.apache.parquet.format.converter.ParquetMetadataConverter.addRowGroup(), where...

[Timothy Miller](https://issues.apache.org/jira/browse/PARQUET-2139?#comment-17525272) / @theosib-amazon: I just noticed that the file_offset field in ColumnChunk is "required." So there's a few possible mistakes: 1. The description of the metadata structures is wrong...

[Edward Seidl](https://issues.apache.org/jira/browse/PARQUET-2139?#comment-17850521) / @etseidl: In light of the recent metadata discussions on the mailing list [1] I did a similar exercise as the reporter and came to the same conclusion....

[Gang Wu](https://issues.apache.org/jira/browse/PARQUET-2139?#comment-17850538) / @wgtmac: I just checked parquet-cpp and parquet-java: - parquet-cpp follows the spec: [arrow/cpp/src/parquet/metadata.cc at 6800be9331d88024bf550c77865a06c592a22699 · apache/arrow (github.com)](https://github.com/apache/arrow/blob/6800be9331d88024bf550c77865a06c592a22699/cpp/src/parquet/metadata.cc#L1473-L1478) - CMIW, parquet-java does not set ColumnChunk.file_offset at all....

[Edward Seidl](https://issues.apache.org/jira/browse/PARQUET-2139?#comment-17850552) / @etseidl: @wgtmac I haven't been at my computer, so haven't been able to trace this in working code, but the suspicious line of code is There is...

[Gang Wu](https://issues.apache.org/jira/browse/PARQUET-2139?#comment-17850553) / @wgtmac: Good catch! I was looking for explicit call to ColumnChunk.setFile_offset(). This is definitely a bug IMHO.