fastq-rs icon indicating copy to clipboard operation
fastq-rs copied to clipboard

Add support for Fasta records

Open sstadick opened this issue 5 years ago • 4 comments

Hi! I love your library for how easy it makes it to offload the decompression / reading to a different thread. I often need the same thing for fasta files, so I've tried to add it to what you already have. I tried to take the path of least resistance here.

All tests pass, and the fuzzer seems happy. I have not tried to benchmark to see if I've made it slower than before though. How did you run the original benchmarks?

Lastly, if you'd prefer to keep fastq as is, I'm happy to maintain this fork and rename it something else to indicate it is more than just a fastq parser.

sstadick avatar Mar 21 '20 16:03 sstadick

Hi @sstadick. This looks awesome! I haven't really been using this for quite some time (and mostly forgot it existed to tell you the truth), so I'll need a bit of time to reread the code. But I'll get back to you in the next couple of days about this PR.

aseyboldt avatar Mar 24 '20 09:03 aseyboldt

Hi @aseyboldt, thanks for getting back to me on this! No worries on timeline, I'm just glad this popped up on your radar. I'm pretty sure I'm not the only user of this: https://crates.io/crates/fastq There are dozens of us!

sstadick avatar Mar 24 '20 16:03 sstadick

Hi @aseyboldt, just wanted to bump this PR and see if you've had a chance to look at it.

sstadick avatar Mar 29 '20 22:03 sstadick

@aseyboldt Just wanted to check in on this and see where things were at.

sstadick avatar Jun 16 '20 12:06 sstadick