kcl-akka-stream icon indicating copy to clipboard operation
kcl-akka-stream copied to clipboard

Add build against scala 2.13

Open julianhowarth opened this issue 5 years ago • 6 comments

Is it possible to start publishing artifacts against scala 2.13?

julianhowarth avatar Jan 09 '20 15:01 julianhowarth

I have adjusted the sbt build locally and can build against 2.13 but I had to:

  • exclude akka 2.4 (not available for 2.13)
  • remove -Yno-adapted-args (no longer valid afaict)
  • remove -Xfuture (no longer valid)
  • upgrade scalatest to 3.1.0
  • add "org.scalatestplus" %% "mockito-1-10" % "3.1.0.0" % Test as scalatest has split out separate modules
  • in DefaultTestContext.scala, replace import org.scalatest.mockito.MockitoSugar with import org.scalatestplus.mockito.MockitoSugar
  • in KinesisWorkerSourceSourceSpec, fix a test failure due to change in error message

julianhowarth avatar Jan 10 '20 11:01 julianhowarth

Hi @julianhowarth, feel free to open a PR with those changes if you think it's worth it.

Hopefully, soon this will be available in alpakka, but we can still release "maintenance" versions.

aserrallerios avatar Jan 20 '20 09:01 aserrallerios

The PR has been merged, so expect it soon on alpakka :)

aserrallerios avatar Jan 22 '20 11:01 aserrallerios

Hello, I am also interested by Scala 2.13 support and also Akka 2.6 support. I don't see the PR you are talking about. I don't understand, this project is now integrated into alpakka?

joelvim avatar Feb 04 '20 07:02 joelvim

Hi @joelvim.

Yes, this project is deprecated in favor of the alpakka KCL components. The PR is this one:

https://github.com/akka/alpakka/pull/1667

The code has been integrated but not a new alpakka release has been made, so we'll need to wait for Alpakka 2.0.0-M3 or RC/official releases.

I'll try to find some time to document properly the README on this repository and archive it when the alpakka release is made.

aserrallerios avatar Feb 04 '20 08:02 aserrallerios

This is great! Thank you very much for this work!

joelvim avatar Feb 04 '20 09:02 joelvim