skia icon indicating copy to clipboard operation
skia copied to clipboard

added #include <string> to SkShaderCodeDictionary.h

Open paulschnell opened this issue 1 year ago • 1 comments

There was an error when compiling skia on Windows with Clang and Ninja. Compiler threw an error, missing include of std::string. I compiled it successfully after adding this line.

paulschnell avatar Mar 23 '24 22:03 paulschnell

Hi @paulschnell, it's really strange, because the GitHub Actions didn't (don't) fail.

Probably this is required by a specific MSVC (or Windows SDK) version as Clang uses the MS C++ runtime.

dacap avatar Apr 24 '24 00:04 dacap