asdf icon indicating copy to clipboard operation
asdf copied to clipboard

fix: Highlight or mark installed versions when running asdf list all <name>

Open roele opened this issue 3 years ago • 1 comments

Summary

Color highlight installed versions of the list-all command.

Note: It seems asdf does not use colors anywhere, hence we might decide to use another indicator (e.g. ). Simply appending (installed) is visually not distinctive enough IMO. If an icon like indicator is used we might have to think about consistent output formatting.

Uses the internal function list_installed_versions to get all installed versions and adds a color highlight during output iteration.

Since the command latest [--all] uses the command list-all as fallback to get versions, any output format change breaks this functionality. Hence i decided to create an (internal) function list_all_versions which can be used by both commands.

The change lead the test [latest_command - dummy_legacy_plugin] No stable version should return an error to fail which i could not figure out why. It's expecting no output even though the code actually outputs an error "No compatible versions available ($plugin_name $query)". For now i came to the conclusion that maybe previous behaviour might have been faulty.

Fixes: #1152

roele avatar Apr 01 '22 14:04 roele

Removed colored output, fixed tests, shellcheck and shfmt.

roele avatar May 24 '22 19:05 roele