asdf-plugins icon indicating copy to clipboard operation
asdf-plugins copied to clipboard

Remove all test failed plugins from the README

Open smorimoto opened this issue 4 years ago • 40 comments

We are currently considering removing all test failed plugins from the README. Do you have the bandwidth to fix so that the test runs correctly again. Whether you have bandwidth or not, we recently started a collaborative, community-driven project called asdf-community for long-term maintenance of asdf plugins, so consider moving your plugins here. https://github.com/asdf-community/.github

I'm tagging all the authors of the related plugin (in no particular order), but I'd like to hear everyone's opinions.

  • [ ] @Ibotta (Ibotta/asdf-brig)
  • [x] @marciogm (marciogm/asdf-crystal)
  • [x] @mikestephens (mikestephens/asdf-elasticsearch)
  • [x] @vic (vic/asdf-graalvm)
  • [ ] @vic (vic/asdf-haskell)
  • [ ] @rkyleg (rkyleg/asdf-julia)
  • [ ] @sylph01 (sylph01/asdf-mongodb)
  • [x] @richin13 (richin13/asdf-neovim)
  • [x] @particledecay (particledecay/asdf-osctl)
  • [x] @odarriba (odarriba/asdf-php)
  • [x] @code-lever (code-lever/asdf-rust)
  • [x] @mtatheonly (mtatheonly/asdf-scala)
  • [x] @RykHawthorn (RykHawthorn/asdf-tflint)
  • [x] @ndac-todoroki (ndac-todoroki/asdf-v)

smorimoto avatar Jan 25 '20 06:01 smorimoto

CC: @blimmer (Ibotta/asdf-brig)

smorimoto avatar Jan 25 '20 06:01 smorimoto

CC: @nickveys, @gabecook (code-lever/asdf-rust)

smorimoto avatar Jan 25 '20 06:01 smorimoto

Of course, I can help you run the test correctly again.

smorimoto avatar Jan 25 '20 06:01 smorimoto

I do recognize that there are issues for newer versions of mongodb, but its fix is not trivial, and I cannot work on fixing it right away. As such, please remove asdf-mongodb for now, and I will contact you again after fixing it.

sylph01 avatar Jan 25 '20 09:01 sylph01

@sylph01 OK. I'm looking forward to your contact.

smorimoto avatar Jan 25 '20 09:01 smorimoto

I currently don't have bandwidth to maintain asdf-php in any of the ways I would like to (new versions, optimisations, PHP extensions or fixing the tests), so I would agree to transfer it to this community if it starts moving and maintaining this kind of projects.

odarriba avatar Jan 25 '20 12:01 odarriba

@odarriba We already manage a lot of plugins, for example the Standard ML plugin has been transferred by the author. If you okay, I will send you an invitation to prepare for the transfer.

smorimoto avatar Jan 25 '20 13:01 smorimoto

@imbsky let's transfer it then!

odarriba avatar Jan 25 '20 13:01 odarriba

@odarriba Sent!

smorimoto avatar Jan 25 '20 13:01 smorimoto

hey @imbsky. I'm willing to transfer the asdf-crystal as well, could you send a invitation?

marciogm avatar Jan 25 '20 18:01 marciogm

@imbsky Just got asdf-rust fixed up, all green! Thanks for the reminder.

nickveys avatar Jan 26 '20 00:01 nickveys

@marciogm Sent!

smorimoto avatar Jan 26 '20 00:01 smorimoto

@nickveys Thank you! Really quick work!

smorimoto avatar Jan 26 '20 00:01 smorimoto

I fixed the asdf-crystal's CI and dealt with all issues.

smorimoto avatar Jan 26 '20 04:01 smorimoto

@imbsky it looks like there's some kind of issue with Travis CI's badge on that repo. The tests are actually passing, even though the badge says that they're not:

Screen Shot 2020-01-26 at 8 27 03 AM

I opened https://github.com/Ibotta/asdf-brig/issues/8 to see if they can fix up the badge, as I no longer have maintainer abilities on that repo.

blimmer avatar Jan 26 '20 15:01 blimmer

Thank you for checking! Hmm, that's weird... We've created a great tool for GitHub Actions, so it might be a good idea to move to it. https://github.com/asdf-vm/actions

smorimoto avatar Jan 26 '20 15:01 smorimoto

Sounds good. I opened https://github.com/Ibotta/asdf-brig/issues/9 for them to consider, since I don't have maintainer privs anymore. Thanks!

blimmer avatar Jan 26 '20 16:01 blimmer

@blimmer Thank you again for your quick response!

smorimoto avatar Jan 27 '20 00:01 smorimoto

@imbsky Sorry for being late, I've fixed asdf-v. Thanks for the reminder!

ndac-todoroki avatar Jan 27 '20 08:01 ndac-todoroki

@ndac-todoroki Great!

smorimoto avatar Jan 28 '20 12:01 smorimoto

As a whole I think asdf community is a great thing, I'd be happy to pass asdf-elasticsearch off to that

michaelstephens avatar Jan 28 '20 18:01 michaelstephens

@mikestephens I sent you an invitation!

smorimoto avatar Jan 29 '20 08:01 smorimoto

@imbsky Fixed the asdf-scala plugin =)

mtatheonly avatar Jan 30 '20 20:01 mtatheonly

@mtatheonly Thank you!

smorimoto avatar Jan 31 '20 03:01 smorimoto

Nice, I'll also try fixing mines this weekend and transfer them.

vic avatar Jan 31 '20 16:01 vic

Awesome! By the way, most plugins have been fixed by the author or community maintainer. Thanks to everyone who helped us.

smorimoto avatar Jan 31 '20 16:01 smorimoto

Selection_762 This plugin was renamed to "Talos" per #151. Sorry... should have removed osctl. I can submit another PR to remove it.

particledecay avatar Jan 31 '20 20:01 particledecay

@particledecay All right!

smorimoto avatar Feb 02 '20 08:02 smorimoto

I just setup GitHub Actions on asdf-php in https://github.com/asdf-community/asdf-php/pull/31!

smorimoto avatar Feb 12 '20 04:02 smorimoto

I also added CI setup to elasticsearch.

smorimoto avatar Feb 13 '20 09:02 smorimoto