asdf-nodejs icon indicating copy to clipboard operation
asdf-nodejs copied to clipboard

Since nvm v0.40.0 .nvmrc may contain comments

Open sdavids opened this issue 1 year ago • 2 comments

Since nvm v0.40.0 .nvmrc may contain comments.

[New] allow .nvmrc files to support comments


.nvmrc

# comment
20.16.0

This will not work anymore:

https://github.com/asdf-vm/asdf-nodejs/blob/c36e6f065d31437786e587de50f32c85b4972188/bin/parse-legacy-file#L8

sdavids avatar Aug 06 '24 22:08 sdavids

Also, .nvmrc can just list the major version (e.g. 18), but this package doesn't support just being given the major version. Unless that's a limitation of asdf itself, but I don't remember it being...

nmay231 avatar Aug 15 '24 09:08 nmay231

Also, .nvmrc can just list the major version (e.g. 18), but this package doesn't support just being given the major version. Unless that's a limitation of asdf itself, but I don't remember it being...

We do support partial versions inside .nvmrc check the README section about it

augustobmoura avatar Aug 15 '24 17:08 augustobmoura