bigSlide.js icon indicating copy to clipboard operation
bigSlide.js copied to clipboard

EasyClose Issue in iOS 9.3 Safari

Open eric432 opened this issue 8 years ago • 5 comments

It seems with easyClose set to true the menu only closes if you click an actual link in the page (instead of anywhere). In desktop browsers and android I can close by clicking anywhere on the page. I am seeing this behavior on the bigslide.js homepage as well so I suspect it is an new iOS issue?

eric432 avatar Mar 30 '16 23:03 eric432

:disappointed: That's very possible. I've seen other (similar) unexpected behavior in iOS Safari 9+.

ascott1 avatar Mar 31 '16 10:03 ascott1

I tried adding touchstart.bigSlide event on line 203. Seemed to do the job for iOS 9.2 - havent tried 9.3.

ghost avatar Apr 10 '16 22:04 ghost

thanks @topcatcreatives !

mzane42 avatar Jul 11 '16 13:07 mzane42

Current version i have has touchstart.bigSlide on line 204 and I am having an issue with this not closing on touch.... ios 9.3.5

Any other suggestions? I like this tool, but this is a must fix ....

timmeade avatar Sep 01 '16 14:09 timmeade

Ok Line 251 added touchstart.bigSlide fixed my issue:

    if (settings.easyClose) {
      $(document).on('click.bigSlide touchstart.bigSlide', function(e) {
       if (!$(e.target).parents().addBack().is(menuLink) && !$(e.target).closest(settings.menu).length && controller.getState() === 'open')  {
         view.toggleClose();
       }
      });
    }

timmeade avatar Sep 01 '16 14:09 timmeade