react-native-image-viewer icon indicating copy to clipboard operation
react-native-image-viewer copied to clipboard

Warning: componentWillMount has been renamed, and is not recommended for use

Open ghost opened this issue 6 years ago • 24 comments

ghost avatar Oct 28 '19 06:10 ghost

Any updates on this?

chetan-zalake avatar Nov 01 '19 09:11 chetan-zalake

#358 It is merged but not released yet

r0b0t3d avatar Nov 08 '19 10:11 r0b0t3d

Hi ! @ascoders can we release please ? 🙏

devaublanc avatar Nov 18 '19 10:11 devaublanc

👍

jaredegan avatar Nov 25 '19 23:11 jaredegan

+1

Tamenze avatar Dec 02 '19 22:12 Tamenze

looking at whats happening with this package, the solve has actually been rolled out on this side but as @ascoders has a dependency on https://github.com/ascoders/react-native-image-zoom this hasn't actually had any of the fixes applied.

Fixing that would in turn fix this I believe

Trashpants avatar Dec 10 '19 15:12 Trashpants

is there any updates on this issue? I have the warning too after updating to react native 61.

Many thanks guys

LuongTruong avatar Jan 07 '20 01:01 LuongTruong

@ascoders please, can you release the merged PR? Thanks

gsantiago avatar Jan 13 '20 20:01 gsantiago

Hi ! @ascoders can we release?

claudiozam avatar Jan 23 '20 09:01 claudiozam

@ascoders can we get a release?

Egi-B avatar Mar 15 '20 21:03 Egi-B

@ascoders still see error. Warning: componentWillMount has been renamed Is it possible to fix this?

davx1992 avatar Mar 17 '20 15:03 davx1992

Same here

cklinx avatar Apr 03 '20 12:04 cklinx

@ascoders Can you please release a new version?

yaron1m avatar Apr 03 '20 16:04 yaron1m

Would like to see this merged too :)

gerryfletch avatar Apr 03 '20 16:04 gerryfletch

still getting this error on v2.2.27

felipebergamin avatar Apr 15 '20 21:04 felipebergamin

+1 for merge :)

andelh avatar Apr 20 '20 13:04 andelh

+1 for a new release please :) @ascoders

Spoutnik97 avatar Apr 29 '20 07:04 Spoutnik97

+1 for a new release @ascoders

alendra1945 avatar May 06 '20 13:05 alendra1945

Sorry for late reply, due to the large changes, major version upgrade is adopted to prevent the break change. [email protected] is now released!

By the way, anyone want to be a backup maintainer?

ascoders avatar May 10 '20 02:05 ascoders

[email protected] is actually giving 2 warnings:

ComponentWillReceiveProps has been renamed, and is not recommended for use. ComponentWillMount has been renamed, and is not recommended for use.

sjuanati avatar May 10 '20 08:05 sjuanati

Hey guys, I'm a new maintainer for this repo and I'm trying to resolve most common issues right now. Read more in #396. It still might take time to make into release, but at least I can say that next release is soon (like a week or so). I will notify people here to update once the new version is out.

ArtemKolichenkov avatar May 15 '20 21:05 ArtemKolichenkov

Hello @ArtemKolichenkov , thank you for being a maintainer for this project. How are things going, bro?

LuongTruong avatar Aug 10 '20 01:08 LuongTruong

@LuongTruong Hi! I was quite busy this summer unfortunately, sorry for dropping out. Today is my last day at current job, I will wrap things up over here and come back to this repo. Again, sorry for disappearing in summer, had to move and change jobs and bunch of other things 🙁

ArtemKolichenkov avatar Aug 14 '20 06:08 ArtemKolichenkov

This warning shows up in React Native newer version. React Native homepage provides that those life cycles will be removed after newer upgrade, so it suggest you to use UNSAFE keywords or move methods to the other function. I just solved it by ignoring yellow box or warning. Look up this document: https://ko.reactjs.org/docs/react-component.html

1sanguk avatar May 11 '21 04:05 1sanguk