atom-asciidoc-preview icon indicating copy to clipboard operation
atom-asciidoc-preview copied to clipboard

Published 20 hours ago • verified publisher icon asciidoctor

Add additional values to toc option

Open mojavelinux opened this issue 6 years ago • 1 comments

Description

The toc option currently does not reflect all the possible values. It's missing:

  • not set (present, but called "none")
  • on (the same as a blank value, or -a toc)
  • off (the same as unset, or -a toc!)

The current "none" value is acting as the "not-specified" value, but it is not clear enough to the user that this is what the option means. In fact, I would prefer the name "not set" for this value as this terminology is consistent with the Asciidoctor user manual.

If we decide to rename "not-specifed" to "not set", then we should also change the corresponding value for the section numbering option.

  • Atom version: 1.20.0-beta1
  • OS: Fedora
  • asciidoc-preview version: 2.10.2

mojavelinux avatar Sep 20 '17 04:09 mojavelinux

Today we have 3 options:

https://github.com/asciidoctor/atom-asciidoc-preview/blob/fd76a3e0c3ac8184a45c67933eada8a5564c2850/package.json#L79-L90

In the code: https://github.com/asciidoctor/atom-asciidoc-preview/blob/fd76a3e0c3ac8184a45c67933eada8a5564c2850/lib/configuration-builder.coffee#L21-L30

Do you want me to add 2 new options and rename none to not-set?

ldez avatar Oct 14 '17 22:10 ldez