asciidoctorj
asciidoctorj copied to clipboard
Fixes #942. When an Asciidoctor instance is created with a classloade…
…r parameter, use this classloader also to autoregister extensions, converters, syntax highlighters and loggers.
Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
- [x] Bug fix
- [ ] New non-breaking feature
- [ ] New breaking feature
- [ ] Documentation update
- [ ] Build improvement
Description
What is the goal of this pull request?
When an Asciidoctor instance is created with AsciidoctorJRuby.create(ClassLoader), the given classloader should not also be used to let JRuby find the Asciidoctor gem, but also to auto register extensions etc.
Are there any alternative ways to implement this?
Possibly.
Are there any implications of this pull request? Anything a user must know?
Yes! This should be thoroughly tested in the different environments like the gradle plugin, maven plugin and Osgi, as all of these environments might behave differently wrt class loading.
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #942
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc