WIP: Integration of asciidoctor-web-pdf instead of wkhtmltopdf

[danyill]

Resolves #433.

Still working on this and need to think about acceptance criteria, testing on Mac/Windows, options which need to be added for asciidoctor-web-pdf etc.

[rogierhofboer]

Please do not replace wkhtmltopdf (yet), but make asciidoctor-web-pdf an option next to it.

I've tried asciidoctor-web-pdf and when a table is crossing page boundaries, it produces errors, the table is not shown and skips the rest of the document. No umlauts or other special characters are used. It seem to be this issue: https://github.com/Mogztter/asciidoctor-web-pdf/issues/267

There is no problem rendering the same document with wkhtmltopdf.

[danyill]

Thanks for the feedback. This is only a draft and perhaps we need to wait for further improvements in asciidoctor-web-pdf.

I'm also somewhat confident that the binary versions of asciidoctor-web-pdf also aren't working quite as I had hoped (there may be a memory leak, I need to examine further).

However I don't think retaining wkhtmltopdf is viable anymore. We are using an old binary that is not easily able to be updated and we have quite a few issues logged against it.

There are many VS Code extensions which allow you to run an executable command against a file, for instance:

• Run On Save
• Terminal Commands
• etc

Would these be reasonable alternatives for you?

[ggrossetie]

However I don't think retaining wkhtmltopdf is viable anymore. We are using an old binary that is not easily able to be updated and we have quite a few issues logged against it.

Indeed, we rely on https://github.com/joaompinto/wkhtmltopdf/releases but I'm not sure how to update/publish a new release? @joaompinto if you have time, it would be great if you could tell us how to create a new release from the binaries https://wkhtmltopdf.org/downloads.html?

Alternatively, we could remove the download feature and tell users that they need to install the latest version from https://wkhtmltopdf.org/downloads.html?

Please do not replace wkhtmltopdf (yet), but make asciidoctor-web-pdf an option next to it.

I agree, we should introduce this new feature as an option. I feel like users are somewhat happy with wkhtmltopdf. And, since Asciidoctor Web PDF is experimental we should give them the choice.

[danyill]

Regrettably this PR is now so dated and I am unlikely to address it soon, so it would be better to start from scratch. I'll close on this basis.