asciidoctor-stylesheet-factory icon indicating copy to clipboard operation
asciidoctor-stylesheet-factory copied to clipboard

resolves #19 - migrate to Foundation 5

Open mojavelinux opened this issue 10 years ago • 5 comments

  • migrate from Foundation 4 to Foundation 5
  • upgrade to Compass 1.0.1
  • make stylesheet changes necessary to accomodate upgrades
  • add Bower configuration
  • update README with information about Bower requirement
  • refactor handling of trailing margins in asciidoc component
  • drop old themes: iconic, colony, maker, rubygems
  • rework readthedocs theme to match new theme on readthedocs.org
  • add motion theme
  • improve build-stylesheet.sh script
  • declare custom sass functions
  • fix background colors for sidebar & example blocks in asciidoctor theme
  • many minor refinements to styles & scss source

mojavelinux avatar Jan 05 '15 08:01 mojavelinux

I will do a code review this week-end :smile:

ggrossetie avatar Mar 30 '16 21:03 ggrossetie

:+1:

mojavelinux avatar Mar 30 '16 21:03 mojavelinux

https://github.com/Huddle/PhantomCSS is looking great, I will try to setup a simple script to automate visual testing.

ggrossetie avatar Apr 01 '16 18:04 ggrossetie

I'd be happy to pick up the PhantomCSS testing. Could you give me some pointers on where to put the automated visual testing?

It would be nice to push onto Foundation 6, but there isn't a migration guide that I've seen. I'd be happy to dig in.

I have got asciidoctor to compile with libsass (via node-sass and bower) which means that Ruby can go altogether. This might be something to explore, as libsass is more portable than compass/ruby. I used a compass-mixin library from bower.

SevereOverfl0w avatar Aug 04 '16 15:08 SevereOverfl0w

Hello @SevereOverfl0w

I'd be happy to pick up the PhantomCSS testing. Could you give me some pointers on where to put the automated visual testing?

I've done some work with PhantomCSS here: https://github.com/asciidoctor/asciidoctor-stylesheet-factory/pull/30 The basic idea was to produce a screenshot of the Asciidoctor User Manual before and after the migration.

During my tests, I've only found one small "regression", so I think it's safe to merge this pull request and work on the next migration (Foundation 5 > Foundation 6). Otherwise we will fall behind quickly :cry:

ggrossetie avatar Aug 05 '16 14:08 ggrossetie