asciidoctor-intellij-plugin icon indicating copy to clipboard operation
asciidoctor-intellij-plugin copied to clipboard

Add horizontal split between source and preview in toolbar

Open augustozanellato opened this issue 4 years ago • 5 comments

It should be possible to choose between horizontal (actual behavior) or vertical splitting when viewing both source and preview.

An example use case would be if I already have the IDE horizontally split I could use the V-split in order to not have a too small preview.

EDIT: just discovered that's already possible by changing plugin settings, maybe that toggle should be moved to the toolbar for quicker access

augustozanellato avatar Aug 27 '20 10:08 augustozanellato

Hello @augustozanellato, thanks for using this plugin.

I'd like to keep the tool bar for items that users use frequently, and for things that user change on a per-editor level.

Changing horizontal vs. vertical split is something that I assume users don't change frequently, and not on a per-editor level.

Therefore I'd like to keep it settings-only.

If you think this feature is hard to discover and should be mentioned (or the user should be notified) in a specific location or situation, please let me know.

The configuring preview section mentions the settings, but doesn't highlight all the settings that are available. The feature is briefly mentioned in the preview feature overview.

ahus1 avatar Aug 30 '20 18:08 ahus1

Hi @ahus1, Thank you for developing such an awesome extension!

My fault for not looking at the plugin settings before opening the issue.

Regarding the horizontal/vertical setting I find myself changing split direction 2-3 times a day, not so often but also not so rarely. For me it depends on if I’m doing pure doc writing work (so one editor, V-split) or if I’m doing documentation for some code I wrote (two editors V-split, asciidoc H-split)

augustozanellato avatar Aug 30 '20 19:08 augustozanellato

Thank you @augustozanellato for describing the situation you want to use it in.

Just to make sure I am on the same page: Please note that the toolbar affects only the current editor.

Should this be "sticky" like the preview behaves today, or "transient" like the line wrap behaves today?

"transient": reset to the default defined in the settings once you close/re-open the editor for a given file.

"sticky": file would memorize its setting when you close/re-open the editor for a given file

ahus1 avatar Aug 30 '20 19:08 ahus1

That’s actually a good question! I think that having a sticky setting would be better for me, but I think it heavily depends on every one’s use case

augustozanellato avatar Aug 30 '20 20:08 augustozanellato

Hi there, I would like this to be available in the toolbar, maybe by pressing Alt on the button.

As I'm on a laptop, I often plugin/plugout an external screen multiple time a day. On my external screen I would prefer a vertical split, while on the laptop I would prefer an horizontal one. So having the ability to change split direction would definitely be appreciated.

Regarding transient or sticky behavior, both have their pros, however I would personnaly prefer the sticky one.

bric3 avatar Oct 22 '20 09:10 bric3