asciidoctor-gradle-examples icon indicating copy to clipboard operation
asciidoctor-gradle-examples copied to clipboard

asciidoc-diagram-to-pdf-example

Open jeffcjohnson opened this issue 6 years ago • 3 comments

This works for saving diagrams to PDF but does not work with static images at the same time.

The copy command doesn't seem to be doing anything.

jeffcjohnson avatar Feb 08 '19 18:02 jeffcjohnson

@mojavelinux I have two places in the Gradle build file that try to copy the static images to the build dir but neither seem to work. It might be something I'm doing wrong in Gradle but I also wonder if asciidoc is wiping out $buildDir/asciidoc/pdf/images when it starts up.

Any thoughts?

jeffcjohnson avatar Feb 11 '19 20:02 jeffcjohnson

If you are using the latest AsciidoctorJ and Asciidoctor Diagram, you should find that the images are now embedded properly without having to set imagesoutdir. It should be automatic now.

For details, see https://github.com/asciidoctor/asciidoctor-pdf/issues/1033. Basically, Asciidoctor Diagram now works out where to put the images so you don't have to tell it how.

mojavelinux avatar Jun 10 '19 04:06 mojavelinux

I've pushed a commit to your PR that fixes the build.

Before this is merged, I think it makes sense to merge it with the html variant and renaming it to asciidoctor-diagram-example. Can you make that update?

mojavelinux avatar Jun 13 '19 01:06 mojavelinux