asciidoctor-browser-extension
asciidoctor-browser-extension copied to clipboard
asciidoctor
[FF nightly] Works erratically with FF nightly
So with recent nightlies (last 1 week+), the browser extension does not transform documents all the time and behavior is erratic. Opening a *.adoc file just shows the text in the browser - almost as if the plugin in never triggered.
If you'd only want to consider stable versions, I completely understand - so feel free to close this issue (though I'd appreciate any tips/pointers on how to go about debugging this)
Hello @raghur, do you have a stack trace on the console ? could you please also check the background page ?
Thanks :grinning:
Seems to happen only if webrender is turned on. I've turned off webrender for now and it works fine.
Thanks for the tip @raghur! It seems that the nightly release has become a daily release, because I have the same issue in the regular (up-to-date) portable firefox right now…
Hum… too bad :-( Turning off (which it already was, in fact) webrender (gfx.webrender.enabled) does nothing for me.
@Mogztter - seems to have righted itself... I'm on the latest nightly and turned on webrender and .adoc files are rendered properly.
@tYYGH - AFAIK, webrender isn't available on anything other than nightly [gfx.webrender.enabled] isn't useful. If you truly want to check, you can go to the about:support page and you should see something like:
@tYYGH What version of Firefox are you using ? Are you trying to render a document from GitHub ? If it's the case, could you try to render a local document ?
@raghur Excellent, thanks for the head-up :+1:
@Mogztter: I’m using Portable Firefox 60.0.2 (64 bits). The Asciidoc file is on my local drive (file://…).
However, I have just found that placing the focus in the URL bar and hitting the Enter key triggers live formatting by Asciidoclive.js again! It’s still a regression compared to former behaviour, but at least it’s an easy work-around :-) (And no, Ctrl+R, or Ctrl+Shift+R, or Ctrl+F5… do not fix the issue; only Enter in the URL bar does)
I'm observing exactly the same problem. The workaround mentioned by @tYYGH works for me. Great find!
To be clear, this seems to happen when navigating from the file browser view into a file. If I visit the file directly from the URL, then the extension fires.
@raghur Could you please confirm that this issue is a duplicate of #256 (or the other way around) ?
@tYYGH I've created a pull request to document this issue #262
@Mogztter looked at #256. On my windows machine with nightly, I can drop a *.adoc file onto the browser and it renders properly. I'll check on linux later when I'm at my desktop. I'm running nightly there too, though.
@raghur If you drop a .adoc file onto the browser, Firefox will render the file (also works on Linux). But if you remove the filename in your address bar and use the file explorer to open it again then the extension will not be triggered. Could you please try that on nightly Windows/Linux ?
Tried that on Win8.1 with FF nightly and can confirm that extension isn't triggered when browsing adoc files from the ff file explorer.