plugin.video.netflix icon indicating copy to clipboard operation
plugin.video.netflix copied to clipboard

Credentials unit tests

Open tomjshore opened this issue 5 years ago • 0 comments

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] I have read the CONTRIBUTING document.

This is to add unit tests to the NetflixCredentials class. The only change to "real" code was to change the if statements on string validation so the when encoding/decodeing it will return empty string if email or password is empty (this seems to be the intention viewing the code comments).

All Submissions:

  • [x] Have you followed the guidelines in our Contributing document?
  • [x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [x] Have you successfully ran tests with your changes locally?

tomjshore avatar Aug 20 '19 16:08 tomjshore