aschzero
Use filter codes instead of filter names
Hey, thanks for writing this great plugin! I noticed that I would get errors in Homebridge when the filter status was requested, and after some debugging, I see that I'm getting Korean names returned for the two filters (극세사망 프리필터 and Max2 필터). My app appears in English, though, and I don't see any way to change my language settings, so I thought it might be a little bit more defensive to refer to filters by their "codes" rather than their names. The pre-filter has code 3121332 and the main filter has code 3111735.
This PR assumes the codes are stable across devices. Please let me know if you have any feedback, and again, thank you for putting this together!
Hey @aschzero -- any thoughts on this? I'd appreciate a review and merge if you have a moment to look it over and you think this is a good fix for the filter issue.
Do you want to pick up ownership of this plugin and merge this thing in? since it doesn't look like the creator is going to. If not, I can make a fork.
Hey @nathanfjohnson -- If you're willing to make a fork and take ownership, that sounds good to me (not the owner of this repo, for full clarity/transparency). Apologies that I haven't had more time to make my own fork. I'm not a Node/JS developer by trade, and I haven't had enough time to sort out Typescript issues I ran into when I briefly tried to create a fork a few weeks or months ago when I last attempted to put up my own version.
@nathanfjohnson, please fork this and start a new as the original author has clearly abandoned it. I have also found an issue I do not believe is reported that would be great to fix. I will open it in the issues list. Hoping you could help.
@nathanfjohnson I know you're moving on to HomeAssistant, but I gave that a shot and have decided to stick with Homebridge. I'm looking into picking this project up myself even though I'm completely new to js/ts/npm/homebridge. Wondering if you or @shamanskyh can help me out 1 more time. I've got the ts compiling to js for almost the whole project, but for some reason the util folder and the aes.js isn't created when I run the npm commands. Any advice on what a rookie could be missing to make that folder compile?