Magento-SMTP-Pro-Email-Extension icon indicating copy to clipboard operation
Magento-SMTP-Pro-Email-Extension copied to clipboard

Clears recipients before putting message in queue

Open mmenozzi opened this issue 6 years ago • 2 comments

In recent versions of M1 (https://github.com/bragento/magento-core/blob/a1f699085c04af6ee6080d3228557edd45b0080c/app/code/core/Mage/Core/Model/Email/Template.php#L410) there's this $emailQueue->clearRecipients(); before putting the message into the queue (I think for securty reasons). This change brings this behavior into this module.

mmenozzi avatar Oct 29 '18 16:10 mmenozzi

Hey, man. I am wondering is this possible that your pull request will be applied ?! :D

ant-workaholic avatar Jan 03 '19 20:01 ant-workaholic

btw it's not just for security reasons, it's to resolve bugs in reuse of the email queue causing previous recipients getting the same email (therefore a privacy issue). Since the lifecycle of the email queue is managed outside of the email template, it's harder to determine if existing code is affected, but this fix should be applied as it has in core.

andytson-inviqa avatar Aug 19 '19 08:08 andytson-inviqa

Duplicates https://github.com/aschroder/Magento-SMTP-Pro-Email-Extension/pull/289 Merged there. Thanks for contribution! Closed

borriglione avatar Jun 18 '24 09:06 borriglione