drf-tracking
drf-tracking copied to clipboard
switch decode source encoding from ascii to utf-8
UnicodeDecodeError fix on python 2.7 / django 1.11 #129
Tested with Python 2.7.15 / Django 1.11.16 and Python 2.3.7 / Django 2.1.3
Could you please update it with latest master
branch? Another parameter (errors='replace'
) has been added to data.decode()
.
Hi ! I was wondering if there's something blocking this pull-request. I saw a pyFlake error on travis , how can I help ?
@martync Fix the pyFlake would help here I think. It also has merge conflicts.
I can't reproduce this error at home nor on travis : tests/test_mixins.py:385:13: E117 over-indented
I have another failure that concerns pypi (which is normal) : https://github.com/martync/drf-tracking/commits/master but no pyflake errors here 🤔
@avelis can you re-trigger this travis build ? If it still fails, I'll make a pull request from my repo
@martync I restarted it. You can follow its progress here: https://travis-ci.org/aschn/drf-tracking/builds/531659171
Hi @avelis any chance you have time to create a new release with this fix ?
@martync I can try and take a look after the holiday break.
@martync This needs a rebase in order to be merged.