drf-tracking icon indicating copy to clipboard operation
drf-tracking copied to clipboard

Remove query_params explicity conversion to dict

Open umr55766 opened this issue 6 years ago • 2 comments

  • This explicit conversion to dict is dropping all the values with same key
  • This is already being done in line 169 https://github.com/aschn/drf-tracking/blob/57344c65fe39923ab2debbf581d9fd0dbc46b2fa/rest_framework_tracking/base_mixins.py#L169
  • Fixes #126

umr55766 avatar Nov 13 '18 10:11 umr55766

@umr55766 Can you address the failing tests before I take a look?

avelis avatar Nov 13 '18 16:11 avelis

@umr55766, i looked into failing tests and i think they should include client calls with different content_type:

  • 'multipart' (default in drf tests) which will return lists
  • 'json' which is expected to have single string values

simone6021 avatar Feb 07 '19 09:02 simone6021