Adin Schmahmann

@marten-seemann what are you trying to do here and how did you generate the bytes in `data`? You're taking a bunch of bytes (`data`) and passing them to a function...

I think this is one of those things that sits on the performance strictness spectrum. `FromCid` https://github.com/libp2p/go-libp2p-core/blob/83ac1d370dfe3f04aee38a904f73e49070be4863/peer/peer.go#L198 which is internally called by `peer.Decode` and `id.UnmarshalText` should probably check if the...

@marten-seemann unfortunately https://github.com/libp2p/go-libp2p/issues/1592 is insufficient. There were a couple deficiencies called out in the PR https://github.com/libp2p/go-libp2p/pull/1592#issue-1265537876 (e.g. #9199 and this). I suspect @olizilla is correct in that the peerstore is...

@Jorropo AFAICT that doesn't appear related to this issue, it's just a separate issue related to #9199 that already exists. Also a PR dealing with DI code is already linked...

Yep seems reasonable. We should probably use the go-log format (https://github.com/ipfs/go-log#golog_log_level) for describing particular subsystems to get logs for though.

@gammazero your go.mod files are conflicting with master. Could you rebase when you get a chance?

This is blocked by the badger folks figuring out if there latest breaking changes will be handled within badger v2 or whether there will be a badger v3. The go-ipfs-config...

To clarify, I was mostly alluding to some of the string related issues brought up in https://twitter.com/AssemblyScript/status/1566702136435539968 and the linked post. Depending on where you draw the boundaries IPLD might...

@pgte @jimpick A couple thoughts about fuzzing that might be helpful (or obvious/irrelevant). +1 to deterministic unit tests, especially if network conditions are potentially effecting the outcomes. For randomness that's...

@dirkmc @pgte I've been following this a little bit and had a couple questions just to give me some context on the what and why for this proposal. Are there...