Asbjørn Ulsberg
Asbjørn Ulsberg
@CharliePoole Sorry, haven't seen it until now. And it's way past bedtime, so I'll have to look at it tomorrow. 😴
If the branch `issue-199` is created from the current tip of `master` (commit 49ec2a90884a87792162557c9dc4791c2966ccaa), my local graph should look fairly similar to yours. This is what I'm seeing in SmartGit's...
To see reachable commits from the current one, you can do this on the command line: ``` shell git log --graph --format="%h %cr %d" --decorate --date=relative --all --remotes=* ```
Hmyea, I didn't realize we've already merged stuff in the 2.0.0 milestone. That's a bit unfortunate. We should probably branch out to `support/1.x` from before #77 was merged so we...
> this ok: https://github.com/linked-data-dotnet/json-ld.net/tree/support/1.x ? Since it's branched out from be001896a72eef6a5e3251cb250a47de0550dc28, just before the merge of #77, it should be good. 👍
I agree the current design is sub-optimal, @goofballLogic. But I'm not fond of returning `string`. Can we return an object that matches `RDFDataset` but is controlled by us?
> I propose that given the nature of this library which should aim to support the lowest version of .NET standard across all the different platforms. What does that mean,...
I think such a separation and refactoring of the code base makes a lot of sense, @goofballLogic. I'm a strong proponent of having a core domain model completely dependency-free and...
100% agreed, @goofballLogic. Static, state- and side-effect-free methods make sense in a functional language, but in C# where DI containers are prevalent, immutability is difficult to guarantee and (shared) state...
I guess because #80 was only merged yesterday, @goofballLogic.