build-time-tracker icon indicating copy to clipboard operation
build-time-tracker copied to clipboard

Provide option to suppress output

Open ZivSharifi opened this issue 3 years ago • 8 comments

Read first

  1. Do not open issues for questions, use https://github.com/asarkar/build-time-tracker/discussions instead.
  2. Have you searched in issues and discussions for a similar problem?

Is your feature request related to a problem? Please describe Description of what the problem is.

Hey, i want to have this feature disabled as default, and only show in CI/if user adds a parameter. I haven't seen this option. i think will be helpful.

Describe the solution you'd like Description of what you want to happen.

add configuration for enable (true/false).

Describe alternatives you've considered Description of any alternative solutions or features you've considered.

Environment

  • build-time-tracker plugin version: 4.0.3
  • OS: linux
  • Gradle version: 7.2
  • JDK version: 17

Additional context Add any other context or screenshots about the feature request here.

ZivSharifi avatar Aug 16 '22 08:08 ZivSharifi

See https://github.com/asarkar/build-time-tracker/discussions/48

asarkar avatar Aug 16 '22 15:08 asarkar

By design, once added, Gradle plugins are always enabled. You didn’t mention the reason behind your request, and what benefit, in your opinion, it might bring. Feel free to elaborate if you want this issue to be reconsidered.

asarkar avatar Aug 16 '22 17:08 asarkar

Hey, thanks for the reply. Maybe what I mean is toggle the output. Let’s say a developer doesn’t need this output while developing (unless on specific performance test). But on CI build it is insightful with every run. So not to disable the feature, but toggle the output on and off.

ZivSharifi avatar Aug 17 '22 04:08 ZivSharifi

An option to suppress the output seems reasonable. Can you show how you want to toggle the output depending on the environment?

asarkar avatar Aug 18 '22 00:08 asarkar

Sorry for misunderstanding, should I show it via PR? or write the general idea here?

An option to suppress the output seems reasonable. Can you show how you want to toggle the output depending on the environment?

Sorry for misunderstanding, should I show it via PR? or write the general idea here?

ZivSharifi avatar Aug 19 '22 06:08 ZivSharifi

A PR is definitely appreciated but you can also show some code snippet here as to how you intend to use the output.

asarkar avatar Aug 19 '22 08:08 asarkar

Hey, sorry, was on vacation fir the past two weeks. will try to attach PR this week.

ZivSharifi avatar Aug 30 '22 10:08 ZivSharifi

Before making a PR, I’d like to see how you intend to flip the output based on the environment. Currently there are two output formats, console and CSV. Why don’t you try and switch between them, perhaps based on the presence of an environment variable? If you’re able to do that, then adding another output option is going to be trivial for your use case.

asarkar avatar Aug 30 '22 20:08 asarkar

This issue is stale and will be closed in 5 days.

github-actions[bot] avatar Oct 02 '22 01:10 github-actions[bot]