ng-s3upload icon indicating copy to clipboard operation
ng-s3upload copied to clipboard

Published 20 hours ago • verified publisher icon asafdav

Some new configuration options

Open joelturnbull opened this issue 9 years ago • 4 comments

I used your directive to replace an old backbone video uploader in our app, but we had some specific needs that I thought I'd submit as new configuration options. I have each of these new options split out as a separate branch if you prefer them that way. Thanks!

  1. We needed to tweak the UI a bit so I added the ability to set the templateUrl to file outside of the project.
  2. For whatever reason, our s3 is setup to forbid requests having the Content-Type header so I added an option to suppress adding that.
  3. Last, we save our files using the original filename so we can display that to the user who uploaded them. Added the ability to preserve and save the file using the original filename.

joelturnbull avatar Jul 23 '15 18:07 joelturnbull

Hi @joelturnbull, Thank you for this pull request, I want to merge it. I'm about to merge #55 that already tackles your first item so after I merge it, I'll take another look at your pull request and see how to combine it.

Thanks again !

asafdav avatar Aug 08 '15 19:08 asafdav

Great! Thanks @asafdav

joelturnbull avatar Aug 21 '15 17:08 joelturnbull

@joelturnbull @asafdav would love to see the originalFileName option feature being merged.

Is there anyway to achieve that with the current version btw?

Thanks! :heart:

steverob avatar Nov 30 '15 11:11 steverob

Hi @steverob, thanks for the reminder. I merged #55 today, I will try to find some time and go over this pull request soon.

asafdav avatar Dec 01 '15 07:12 asafdav