Fixes IE and Safari utilizing feature checks

Open frankmariette opened this issue 10 years ago • 8 comments

Added in fixes for IE and Safari. The Safari "fix" just writes the data to a URI and allows it to be saved as a csv with the page source. Didn't want to use a polyfill for flash with the recent vulnerabilities for Flash. While this isn't ideal it is better than nothing. The IE fix was originally created by @BerangereMartin and I modified it to work with the current version of ng-csv.

Dec 01 '15 17:12 frankmariette

Hi can you please squash your commits ?

Dec 17 '15 03:12 asafdav

@asafdav Squashed them down.

Dec 17 '15 03:12 frankmariette

Hi @karrde00, you need to push -f after a squash otherwise all of the old commits stay and it leads to issues. there should be only one commit under the commit tab (currently 11)

Dec 17 '15 13:12 asafdav

Thanks again

Dec 17 '15 13:12 asafdav

@asafdav Fixed it. Thanks for the help on the squash.

Dec 17 '15 15:12 frankmariette

@asafdav What's the status on this?

Jan 08 '16 16:01 frankmariette

curious about the status of this as well.

May 06 '16 20:05 eraye1

+1 to merge this PR

Sep 15 '16 07:09 qdequippe