Asad Sahi

Results 15 comments of Asad Sahi

great job @RezaHaidari works perfect for me. I have just upgraded based on your changes a project which is based on vue-hackernews.

@RezaHaidari in webpack.base.config.js you have added uglifyjsplugin with sourcemaps: ``` if (isProd) { config.optimization = { ...config.optimization, minimizer: [ new UglifyJsPlugin({ sourceMap: true, uglifyOptions: { compress: { inline: false, },...

@sirlancelot you are right. But I was also wondering how to enable sourcemaps in production with --mode=production. First I though this pull request is achiving that with uglifyjsplugin, but there...

@larkin-nz I realised it as well some warnings with extract-text-webpack-plugin. Existing [webpack 4 upgrade pull request ](https://github.com/vuejs/vue-hackernews-2.0/pull/293)works with similar warnings but it produces the bundle correctly and works for me....

This sounds slightly similar issue I was having when I upgraded webpack-dev-middleware to 3.x but had to revert back to 2.x. The issue I was having was on Windows OS...