Asad Sajjad Ahmed

Sorry for the long RTT, I must have forgotten about it. All of your comments should have been addressed now, if not let me know.

Thanks for the review comments, it should have been addressed now. Let me know if this needs more bikeshedding.

How about: ```c $ grep _PTHREAD_H /usr/include/pthread.h #ifndef _PTHREAD_H #define _PTHREAD_H 1 ``` ```c #ifdef _PTHREAD_H #error "Err" #endif ``` Not sure how portable this is... EDIT: nvm.

How about this? ```diff diff --git a/bin/varnishd/mgt/mgt.h b/bin/varnishd/mgt/mgt.h index 2610aaf75..84fb22e6b 100644 --- a/bin/varnishd/mgt/mgt.h +++ b/bin/varnishd/mgt/mgt.h @@ -251,6 +251,11 @@ extern const char *mgt_vmod_path; #error "Keep pthreads out of in manager...

There seems to be lock contention when writing to the shared memory. Please confirm that you have mounted `/var/lib/varnish` as tmpfs. Otherwise, writing to the shared memory would invoke disk...

> @asadsa92 afaict this is on a regular xfs volume. > > I have a few tmpfs mounts on this machine, including `/dev/shm/` but `/var/spool/varnish` (in our case - not...

That's very likely the source of this. If the snapshot takes long time to produce then the manager process of Varnish will observe the child not responding as the backtrace...

@laalsaas You are right, sorry I got confused a bit.

Does it make sense to take it one step further and introduce a way for the vmod author add information to the panic? As we are already changing the format,...

Not relevant to the discussion about what to render on the webpage, but we could always add a `MAINTAINERS` & `CREDITS` file at the root level of the repository.