fastapi-rocket-boilerplate icon indicating copy to clipboard operation
fastapi-rocket-boilerplate copied to clipboard

Quality code: Resolve all the issues showed by trunk check

Open asacristani opened this issue 10 months ago • 2 comments

If you run trunk check -a, there are several issues to resolve.

asacristani avatar Apr 04 '24 14:04 asacristani

@asacristani I want to take on this issue but first I want to ask a couple of questions before proceeding so I can follow the standards that other contributors are following,

  • For PR submission, do we follow this,
    • Clone this repo, create a new branch, make our changes, push it to repo, and create PR to merge into master, if approved, will be merged into master.

Please guide me if we are following a different workflow here.

Also, I setup the project locally and ran trunk check -a and it highlighted a couple of issues in different categories as attached in the snapshot. Do you recommend fixing all of them in one go and submit PR or should I break them like one PR for "unformatted issues" and similarly for other issue types?

issue1

abdur-n-tr avatar May 01 '24 09:05 abdur-n-tr

@abdurrehman11 you are right. Thanks so much for resolving this. I cannot wait for see your solution.

asacristani avatar May 02 '24 15:05 asacristani