fastapi-rocket-boilerplate
fastapi-rocket-boilerplate copied to clipboard
Quality code: Resolve all the issues showed by trunk check
If you run trunk check -a, there are several issues to resolve.
@asacristani I want to take on this issue but first I want to ask a couple of questions before proceeding so I can follow the standards that other contributors are following,
- For PR submission, do we follow this,
- Clone this repo, create a new branch, make our changes, push it to repo, and create PR to merge into master, if approved, will be merged into master.
Please guide me if we are following a different workflow here.
Also, I setup the project locally and ran trunk check -a and it highlighted a couple of issues in different categories as attached in the snapshot. Do you recommend fixing all of them in one go and submit PR or should I break them like one PR for "unformatted issues" and similarly for other issue types?
@abdurrehman11 you are right. Thanks so much for resolving this. I cannot wait for see your solution.