Ali Sabil

Results 23 comments of Ali Sabil
trafficstars

Not ready to merge yet, due to the function `assetNameFromFilePath` which makes assumptions about the location of node_modules/ ```typescript function assetNameFromFilePath(path: string): string { if (path.startsWith(compilerRoot)) { return path.substring(compilerRoot.length); }...

Imagine an endpoint where: ```erlang allowed_methods(Req, State) -> {[, , , , ], Req, State}. ``` and where only the `GET` method should send a content, whereas `POST` and `DELETE`...

I still think that implementing `content_types_provided/2` and returning the `[]` (1) should be equivalent to not implementing it (2). The current implementation handles (1) as reject all requests with 406,...

Hi @mynameisrufus, this library is useful if you want low level MQTT support, and thus requires a bit more setup in order to create a server using it. Among other...

I haven't had much time the last few weeks to look into this in depth, but not that I have, I think this looks really great!

Just sharing some thoughts here, but I think there are 2 issues to be addressed: 1. `null` and `undefined` are conflated. 2. `drop_nulls` lacks context, and exhibits [feature interaction issues](https://en.wikipedia.org/wiki/Feature_interaction_problem)....

Added some printout in `oidcc_http_util:request/4` and it actually looks like there is a "timer" problem: ``` [1720176242986], HTTP: get {"https://myapp-dev.eu.auth0.com/.well-known/openid-configuration",[]} [{timeout,60000}] default [1720176243470], HTTP: get {, []} [{timeout,60000}] default [1720176258475],...

Looks like this helps at least with the accumlation of timers: ```diff diff --git a/src/oidcc_provider_configuration_worker.erl b/src/oidcc_provider_configuration_worker.erl index d4539ec..a9cefa1 100644 --- a/src/oidcc_provider_configuration_worker.erl +++ b/src/oidcc_provider_configuration_worker.erl @@ -224,7 +224,8 @@ handle_continue( %% @private...

> Hm, are they setting a strange cache header that leads to continuous refreshing? Yes, 15 seconds: ``` {"cache-control", "public, max-age=15, stale-while-revalidate=15, stale-if-error=86400"}, ```

Sorry for the delay, finally got to add some logs: ``` [ts: 1722866476154, qlen: 0] handle_continue(load_configuration) [ts: 1722866476629, qlen: 0] handle_continue(load_jwks) [ts: 1722866491632, qlen: 0] handle_info(configuration_expired) [ts: 1722866491633, qlen: 0]...