Arpad Ryszka

this is relevant. At least one service being implemented may need it in the near future. Adding the Help Wanted label.

@NorthFury do you mean that it's not the linked change that causes the problem? https://github.com/zalando/skipper/pull/1547

My suggestion is to revert #1547 and so return to earlier behavior, and to support the use case of #1547 , we should create a filter that achieves the same....

Thanks! As the direction, it looks good to me. I have currently two rather burocratic remarks: - let's not create packages called like 'helpers', too generic and invites future maintainers...

Thanks for raising this topic! I got a weird idea: if we can apply some convention in the naming of these functions, then they might become the most straightforward input...

I think we should proceed with this. Let me explain why. One concern raised by @AlexanderYastrebov is that if the set of helpers diverge from the implementation. It's true that...

> we could likely generate parts of the filter/predicate reference documentation, too. Excellent point! The docs are currently a point where need to be conscious about keeping the godoc and...

i also prefer the separate cleanup interface. There's a convention to call similar things Close() and Closer, do you think that's a good name here? It should be documented that...

I would approach this slightly differently regarding the implementation details: Ideally, we will be able to drop the mandatory and unique route ID from the eskip.Route object (and therefore also...

indeed, I haven't thought of the fixed label keys of Prometheus. We may need to do something 'ugliish', like: - either passing in these label names as a startup option,...