Arpad Ryszka

Results 40 comments of Arpad Ryszka

**Addressed in: https://github.com/zalando/skipper/pull/1555** ~~ `TestInitialAndDeleteFile` times out, possible the loggingtest/logger get stuck at https://github.com/zalando/skipper/blob/master/logging/loggingtest/logger.go#L113 Log output: ``` panic: test timed out after 10m0s goroutine 60 [running]: testing.(*M).startAlarm.func1() /opt/hostedtoolcache/go/1.15.3/x64/src/testing/testing.go:1618 +0x11f created...

Hi Tolgay, currently, this is not possible, because we use a shared connection pool and the individual routes currently don't have control on the connection states. But it's a good...

ok, thanks, will add such tests

@grassator yes, we need this :smile:

@herojan i find named references as filter args a nice idea, but it can have far reaching implications, and considering it all would be better done as a generic redesign...

I like the idea, and also the mentioned risk seems to be less of a problem, because if we extract the token from the cookie into the `Authorization` header, then...

I think this feature should not be a global flag, but rather a filter. Is there a reason or a limitation why it is a global setting?

>> I think this feature should not be a global flag, but rather a filter. Is there a reason or a limitation why it is a global setting? > yes:...

> Would this filter modify what stateBagToTag is doing? the current proposal works more or less like this: 1. defines a set of masks globally, on startup 2. the stateBagToTag...

> that would also work - would we actually be fine to have such a filter in all routes (given that it consumes some memory)? No that's not a problem....