ScrollPager icon indicating copy to clipboard operation
ScrollPager copied to clipboard

Added possibility to turn off adjusting button heights by indicator height

Open wrutkowski opened this issue 9 years ago • 4 comments

Used for high indicators as in implemented example - thirdScrollPager. Also changed order of subviews so that indicator is behind buttons.

wrutkowski avatar Feb 05 '16 16:02 wrutkowski

Thanks for the PR, this could be a good addition, but It feels weird that indicatorHeightShouldAdjustButtonHeight is still using the indicator height

So the flag is set to op, but it doesn't behave as the name would suggest (adjust button height)

screen shot 2016-02-15 at 9 33 52 am

aryaxt avatar Feb 15 '16 17:02 aryaxt

Also please update the code to use tabs instead of spaces to be constant with the rest of the code

aryaxt avatar Feb 15 '16 17:02 aryaxt

Hi, it's still using indicator heights because you can have for example 4pt indicator height, but want the labels to be in the middle of the view instead of shifted a bit top. And setting indicator height to equal with control height we have tabs effect.

I'll fix insertSubview and spaces :+1:

wrutkowski avatar Feb 15 '16 17:02 wrutkowski

aaah, makes sense

aryaxt avatar Feb 16 '16 16:02 aryaxt