aryaantony92
aryaantony92
> Sounds good to me. I can make these changes later this week. Thank you 👍
> Merge conflicts have been resolved and some final modifications made. Thank you.
@Andreas-Koepke I just tested the PR and it's working fine. But, what about moving the conditions like https://github.com/pimcore/pimcore/blob/a4fd44d71f805aa7e48f5475e76adcbcaff97d24/bundles/AdminBundle/public/js/pimcore/asset/asset.js#L495 https://github.com/pimcore/pimcore/blob/a4fd44d71f805aa7e48f5475e76adcbcaff97d24/bundles/AdminBundle/public/js/pimcore/asset/asset.js#L496 in Js files to the controller ? So, we need to...
@Andreas-Koepke Thanks a lot!
@ThisIsJustARandomGuy Thank you. I have adapted your solution and also added unit test for the same.
@natted Yes, the frontend assets for the admin (src/Resources/public/admin) is generated by gulp. And at the moment, we have some issues with the build generation. So, we fixed the issue...
Fixed by https://github.com/pimcore/pimcore/pull/15280
> @aryaantony92 could you describe a bit more what you aim for with this improvement? Maybe I can do a PR if you find it helpful. @yariksheptykin Sure, Thank you!
> Do you what to move [these two services](https://github.com/pimcore/skeleton/blob/11.x/docker-compose.yaml#L66-L89) into a separate docker-compose.yml? Like docker-compose.test.yml? @yariksheptykin Yes exactly. Also, please update the steps in readme that for running codeception, we...