Waleed Khan

Results 200 comments of Waleed Khan

Hi @xEtherealx, thanks for reporting. It looks like it would be possible to determine if the repository is a worktree using [`Repository::is_worktree`](https://docs.rs/git2/0.15.0/git2/struct.Repository.html#method.is_worktree), but I'm not quite sure how to find...

@xEtherealx @cloudhan can you try with #588 and see if it works now? By the way, I haven't tested git-branchless with worktrees, so there might be some issues like https://github.com/arxanas/git-branchless/issues/215.

Hi @ilyagr, thanks for reporting. I agree that this is strange behavior; we should definitely only move local branches. I think this also causes issues if you try to do...

Hi @greg7mdp, thanks for reporting. This situation should definitely be improved. It's worth noting that some git-branchless commands should work even without having run `git branchless init` if it can...

@sunshowers can you approve the workflow runs?

@sunshowers I updated this PR with my latest changes. It looks like for the `basic` test, `CargoConfigs` is picking up the configs in `.cargo/config.toml` instead of `fixtures/nextest-tests/.cargo/config.toml`, which I guess...

@sunshowers Thanks for the feedback. I believe I addressed all the concerns. I think the tests are passing, except for the integration tests which try to run `cargo nextest run`...

I added commit https://github.com/nextest-rs/nextest/pull/534/commits/604e91b7b708f90032cd984350f116a0b9d11ab2 with just my changes to fix the tests. Let me know if you want me to squash the two commits together.

Re CI: - The retry test case on macOS doesn't reproduce for me with `cargo local-nt run --no-default-features`. Is it flaky? - It looks like there's a path-related test failing...